Bladeren bron

Dpkg::Source::Patch: Use number separator to ease readability

Fixes ValuesAndExpressions::RequireNumberSeparators.

Warned-by: perlcritic
Guillem Jover 13 jaren geleden
bovenliggende
commit
c2198a33d0
2 gewijzigde bestanden met toevoegingen van 3 en 2 verwijderingen
  1. 2 2
      scripts/Dpkg/Source/Patch.pm
  2. 1 0
      test/100_critic.t

+ 2 - 2
scripts/Dpkg/Source/Patch.pm

@@ -84,11 +84,11 @@ sub add_diff_file {
 	    my $ts = (stat($old))[9];
 	    my $ts = (stat($old))[9];
 	    my $t = POSIX::strftime('%Y-%m-%d %H:%M:%S', gmtime($ts));
 	    my $t = POSIX::strftime('%Y-%m-%d %H:%M:%S', gmtime($ts));
 	    $opts{label_old} .= sprintf("\t%s.%09d +0000", $t,
 	    $opts{label_old} .= sprintf("\t%s.%09d +0000", $t,
-					    ($ts-int($ts))*1000000000);
+	                                ($ts - int($ts)) * 1_000_000_000);
 	    $ts = (stat($new))[9];
 	    $ts = (stat($new))[9];
 	    $t = POSIX::strftime('%Y-%m-%d %H:%M:%S', gmtime($ts));
 	    $t = POSIX::strftime('%Y-%m-%d %H:%M:%S', gmtime($ts));
 	    $opts{label_new} .= sprintf("\t%s.%09d +0000", $t,
 	    $opts{label_new} .= sprintf("\t%s.%09d +0000", $t,
-					    ($ts-int($ts))*1000000000);
+	                                ($ts - int($ts)) * 1_000_000_000);
 	} else {
 	} else {
 	    # Space in filenames need special treatment
 	    # Space in filenames need special treatment
 	    $opts{label_old} .= "\t" if $opts{label_old} =~ / /;
 	    $opts{label_old} .= "\t" if $opts{label_old} =~ / /;

+ 1 - 0
test/100_critic.t

@@ -87,6 +87,7 @@ my @policies = qw(
     ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator
     ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator
     ValuesAndExpressions::ProhibitVersionStrings
     ValuesAndExpressions::ProhibitVersionStrings
     ValuesAndExpressions::RequireConstantVersion
     ValuesAndExpressions::RequireConstantVersion
+    ValuesAndExpressions::RequireNumberSeparators
     ValuesAndExpressions::RequireQuotedHeredocTerminator
     ValuesAndExpressions::RequireQuotedHeredocTerminator
     ValuesAndExpressions::RequireUpperCaseHeredocTerminator
     ValuesAndExpressions::RequireUpperCaseHeredocTerminator
     Variables::ProhibitAugmentedAssignmentInDeclaration
     Variables::ProhibitAugmentedAssignmentInDeclaration