Bläddra i källkod

perl: Conditionally include modules with require instead of use

Fixes Modules::ProhibitConditionalUseStatements.

Warned-by: perlcritic
Guillem Jover 13 år sedan
förälder
incheckning
724811ab95
3 ändrade filer med 5 tillägg och 4 borttagningar
  1. 2 2
      dselect/methods/Dselect/Ftp.pm
  2. 2 2
      scripts/dpkg-gensymbols.pl
  3. 1 0
      test/100_critic.t

+ 2 - 2
dselect/methods/Dselect/Ftp.pm

@@ -322,7 +322,7 @@ sub do_mdtm {
     #}
 
     if (! $has_mdtm) {
-	use Time::Local;
+	require Time::Local;
 
 	my @files = $ftp->dir($file);
 	if (($#files == -1) || ($ftp->code == 550)) { # No such file or directory
@@ -368,7 +368,7 @@ sub do_mdtm {
 	    }
 
 	    # build a system time
-	    $time = timegm (0, $minutes, $hours, $day, $month, $year);
+	    $time = Time::Local::timegm(0, $minutes, $hours, $day, $month, $year);
 	} else {
 	    die 'Regexp match failed on LIST output';
 	}

+ 2 - 2
scripts/dpkg-gensymbols.pl

@@ -277,8 +277,8 @@ if ($compare || ! $quiet) {
 }
 
 unless ($quiet) {
-    use File::Temp;
-    use Digest::MD5;
+    require File::Temp;
+    require Digest::MD5;
     # Compare template symbols files before and after
     my $before = File::Temp->new(TEMPLATE=>'dpkg-gensymbolsXXXXXX');
     my $after = File::Temp->new(TEMPLATE=>'dpkg-gensymbolsXXXXXX');

+ 1 - 0
test/100_critic.t

@@ -62,6 +62,7 @@ my @policies = qw(
     Miscellanea::ProhibitFormats
     Miscellanea::ProhibitUnrestrictedNoCritic
     Miscellanea::ProhibitUselessNoCritic
+    Modules::ProhibitConditionalUseStatements
     Modules::ProhibitEvilModules
     Modules::RequireBarewordIncludes
     Modules::RequireEndWithOne