Przeglądaj źródła

Fix “dead store” warning from the clang static analyzer.

We only use fullPath later. Subpath is only used temporarily to build the fullPath in one of the cases.
Ryan Olson 12 lat temu
rodzic
commit
36c88e341a

+ 2 - 5
Classes/Global State Explorers/FLEXFileBrowserTableViewController.m

@@ -149,15 +149,12 @@
 
 - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
 {
-    NSString *subpath;
-    NSString *fullPath;
-    
+    NSString *fullPath = nil;
     if (tableView == self.tableView) {
-        subpath = [self.childPaths objectAtIndex:indexPath.row];
+        NSString *subpath = [self.childPaths objectAtIndex:indexPath.row];
         fullPath = [self.path stringByAppendingPathComponent:subpath];
     } else {
         fullPath = [self.searchPaths objectAtIndex:indexPath.row];
-        subpath = [fullPath lastPathComponent];
     }
     
     NSDictionary *attributes = [[NSFileManager defaultManager] attributesOfItemAtPath:fullPath error:NULL];