Browse Source

Remove an unused variable in dpkg-statoverride by renaming it to the
initially indented name. Closes: #425041

Guillem Jover 17 years ago
parent
commit
ee9bb3ca91
3 changed files with 15 additions and 6 deletions
  1. 6 0
      ChangeLog
  2. 3 1
      debian/changelog
  3. 6 5
      scripts/dpkg-statoverride.pl

+ 6 - 0
ChangeLog

@@ -1,3 +1,9 @@
+2007-05-21  Guillem Jover  <guillem@debian.org>
+
+	* scripts/dpkg-statoverride.pl ($pat): Rename to ...
+	($pattern): ... this. Fixes $pattern being an unused variable.
+	($file): Move the declaration to its first usage in the for loop.
+
 2007-05-15  Guillem Jover  <guillem@debian.org>
 
 	* configure.ac: Bump version to 1.14.4~.

+ 3 - 1
debian/changelog

@@ -1,6 +1,8 @@
 dpkg (1.14.4) UNRELEASED; urgency=low
 
-  * 
+  [ Guillem Jover ]
+  * Remove an unused variable in dpkg-statoverride by renaming it to the
+    initially indented name. Closes: #425041
 
  -- Guillem Jover <guillem@debian.org>  Tue, 15 May 2007 16:35:25 +0300
 

+ 6 - 5
scripts/dpkg-statoverride.pl

@@ -167,8 +167,8 @@ if ($mode eq "add") {
 	$dowrite=1;
 	print(STDERR _g("warning: --update is useless for --remove")."\n") if ($doupdate);
 } elsif ($mode eq "list") {
-	my (@list,@ilist,$pattern,$file);
-	
+	my (@list, @ilist);
+
 	@ilist= @ARGV ? @ARGV : ('*');
 	while (defined($_=shift(@ilist))) {
 		s/\W/\\$&/g;
@@ -177,10 +177,11 @@ if ($mode eq "add") {
 		s,/+$,, && print STDERR _g("stripping trailing /")."\n";
 		push(@list,"^$_\$");
 	}
-	my $pat = join('|', @list);
+
+	my $pattern = join('|', @list);
 	$exitcode=1;
-	for $file (keys %owner) {
-		next unless ($file =~ m/$pat/o);
+	for my $file (keys %owner) {
+		next unless ($file =~ m/$pattern/o);
 		$exitcode=0;
 		print "$owner{$file} $group{$file} $mode{$file} $file\n";
 	}