Browse Source

scripts: Pass a list to open() for commands instead of a string

Guillem Jover 9 years ago
parent
commit
d9de01ec25
2 changed files with 3 additions and 2 deletions
  1. 1 1
      scripts/dpkg-scansources.pl
  2. 2 1
      scripts/t/Dpkg_Compression.t

+ 1 - 1
scripts/dpkg-scansources.pl

@@ -306,7 +306,7 @@ sub main {
     load_src_override $src_override, $override;
     load_override_extra $extra_override_file if defined $extra_override_file;
 
-    open my $find_fh, '-|', "find -L \Q$dir\E -name '*.dsc' -print"
+    open my $find_fh, '-|', 'find', '-L', $dir, '-name', '*.dsc', '-print'
         or syserr(g_('cannot fork for %s'), 'find');
     while (<$find_fh>) {
     	chomp;

+ 2 - 1
scripts/t/Dpkg_Compression.t

@@ -60,7 +60,8 @@ sub check_uncompressed {
 
 sub check_compressed {
     my ($filename, $method) = @_;
-    open(my $read_fh, '-|', "zcat $tmpdir/myfile.gz") or die 'cannot fork zcat';
+    open my $read_fh, '-|', 'zcat', "$tmpdir/myfile.gz"
+        or die 'cannot fork zcat';
     my @read = <$read_fh>;
     close $read_fh or die 'cannot close';
     is_deeply(\@lines, \@read, "$filename correctly written ($method)");