Преглед изворни кода

libdpkg: Do not unnecessarily shut up stdout in t-subproc

The only problematic output comes from stderr.
Guillem Jover пре 12 година
родитељ
комит
c008407f8f
2 измењених фајлова са 3 додато и 2 уклоњено
  1. 2 0
      debian/changelog
  2. 1 2
      lib/dpkg/test/t-subproc.c

+ 2 - 0
debian/changelog

@@ -74,6 +74,8 @@ dpkg (1.17.7) UNRELEASED; urgency=low
   * Require compound literals support in the compiler at configure time.
   * Fix compound literals usage with compilers in C99 mode, by not assigning
     them to static variables.
+  * Test suite cleanup:
+    - Do not unnecessarily shut up stdout in t-subproc.
 
   [ Updated dpkg translations ]
   * German (Sven Joachim).

+ 1 - 2
lib/dpkg/test/t-subproc.c

@@ -81,10 +81,9 @@ test(void)
 {
 	int fd;
 
-	/* XXX: Shut up output, we just want the error code. */
+	/* XXX: Shut up stderr, we don't want the error output. */
 	fd = open("/dev/null", O_RDWR);
 	test_pass(fd >= 0);
-	dup2(fd, 1);
 	dup2(fd, 2);
 
 	test_subproc_fork();