Browse Source

dpkg-source: Use two eq operators instead of a grep

This avoids using grep on scalar context.

Fixes BuiltinFunctions::ProhibitBooleanGrep.
Guillem Jover 13 years ago
parent
commit
9f4b98fab6
2 changed files with 2 additions and 1 deletions
  1. 1 1
      scripts/dpkg-source.pl
  2. 1 0
      test/100_critic.t

+ 1 - 1
scripts/dpkg-source.pl

@@ -286,7 +286,7 @@ if ($options{opmode} =~ /^(-b|--print-format|--(before|after)-build|--commit)$/)
                         error(_g('architecture %s only allowed on its ' .
                         error(_g('architecture %s only allowed on its ' .
                                  "own (list for package %s is `%s')"),
                                  "own (list for package %s is `%s')"),
                               $a, $p, $a)
                               $a, $p, $a)
-                            if grep($a eq $_, 'any', 'all');
+                            if $a eq 'any' or $a eq 'all';
                         push(@sourcearch, $a) unless $archadded{$a}++;
                         push(@sourcearch, $a) unless $archadded{$a}++;
                     }
                     }
                 }
                 }

+ 1 - 0
test/100_critic.t

@@ -34,6 +34,7 @@ if (not eval { require Perl::Critic::Utils }) {
 }
 }
 
 
 my @policies = qw(
 my @policies = qw(
+    BuiltinFunctions::ProhibitBooleanGrep
     BuiltinFunctions::ProhibitLvalueSubstr
     BuiltinFunctions::ProhibitLvalueSubstr
     BuiltinFunctions::ProhibitReverseSortBlock
     BuiltinFunctions::ProhibitReverseSortBlock
     BuiltinFunctions::ProhibitSleepViaSelect
     BuiltinFunctions::ProhibitSleepViaSelect