Move extern declarations to header files and stop defining them as extern

ChangeLog

@@ -1,3 +1,11 @@
+2007-11-29  Guillem Jover  <guillem@debian.org>
+
+	* src/main.c (log_file): Move definition to ...
+	* lib/dpkg-db.h: ... here.
+	* src/configure.c (status_pipes): Remove extern definition.
+	* src/errors.c (status_pipes): Likewise.
+	* lib/tarfn.c (TarExtractor): Do not declare as extern.
+
 2007-11-29  Guillem Jover  <guillem@debian.org>
 
 	* dpkg-deb/build.c (arbitrary_fields): Define as static.

debian/changelog

@@ -16,6 +16,7 @@ dpkg (1.14.12) UNRELEASED; urgency=low
 
   [ Guillem Jover ]
   * Define several private functions and variables as static.
+  * Move extern declarations to header files and stop defining them as extern.
 
  -- Guillem Jover <guillem@debian.org>  Sat, 24 Nov 2007 07:38:13 +0200
 

lib/dpkg-db.h

@@ -174,6 +174,7 @@ void modstatdb_shutdown(void);
 
 extern char *statusfile, *availablefile; /* initialised by modstatdb_init */
 
+extern const char *log_file;
 void log_message(const char *fmt, ...);
 
 /*** from database.c ***/

lib/tarfn.c

@@ -119,7 +119,7 @@ typedef struct symlinkList {
 	struct symlinkList *next;
 } symlinkList;
 
-extern int
+int
 TarExtractor(
  void *			userData
 ,const TarFunctions *	functions)

src/configure.c

@@ -55,8 +55,6 @@ static enum conffopt promptconfaction(const char* cfgfile, const char* realold,
 		const char* realnew, int useredited, int distedited,
 		enum conffopt what);
 
-extern struct pipef *status_pipes;
-
 
 void deferred_configure(struct pkginfo *pkg) {
 	/* The algorithm for deciding what to configure first is as follows:

src/errors.c

@@ -50,8 +50,6 @@ static struct error_report *reports=0;
 static struct error_report **lastreport= &reports;
 static struct error_report emergency;
 
-extern struct pipef *status_pipes;
-
 void print_error_perpackage(const char *emsg, const char *arg) {
   struct error_report *nr;
   

src/main.c

@@ -374,8 +374,6 @@ static void setforce(const struct cmdinfo *cip, const char *value) {
   }
 }
 
-extern const char *log_file;
-
 static const char okpassshortopts[]= "D";
 
 void execbackend(const char *const *argv) NONRETURNING;