Explorar o código

Dpkg::Version: Use the block form for the map function

Fixes BuiltinFunctions::RequireBlockMap.
Guillem Jover %!s(int64=13) %!d(string=hai) anos
pai
achega
485f640303
Modificáronse 2 ficheiros con 3 adicións e 2 borrados
  1. 2 2
      scripts/Dpkg/Version.pm
  2. 1 0
      test/100_critic.t

+ 2 - 2
scripts/Dpkg/Version.pm

@@ -326,8 +326,8 @@ sub _version_order {
 }
 }
 
 
 sub version_compare_string($$) {
 sub version_compare_string($$) {
-    my @a = map(_version_order($_), split(//, shift));
-    my @b = map(_version_order($_), split(//, shift));
+    my @a = map { _version_order($_) } split(//, shift);
+    my @b = map { _version_order($_) } split(//, shift);
     while (1) {
     while (1) {
         my ($a, $b) = (shift @a, shift @b);
         my ($a, $b) = (shift @a, shift @b);
         return 0 if not defined($a) and not defined($b);
         return 0 if not defined($a) and not defined($b);

+ 1 - 0
test/100_critic.t

@@ -43,6 +43,7 @@ my @policies = qw(
     BuiltinFunctions::ProhibitUniversalIsa
     BuiltinFunctions::ProhibitUniversalIsa
     BuiltinFunctions::ProhibitVoidGrep
     BuiltinFunctions::ProhibitVoidGrep
     BuiltinFunctions::ProhibitVoidMap
     BuiltinFunctions::ProhibitVoidMap
+    BuiltinFunctions::RequireBlockMap
     BuiltinFunctions::RequireGlobFunction
     BuiltinFunctions::RequireGlobFunction
     BuiltinFunctions::RequireSimpleSortBlock
     BuiltinFunctions::RequireSimpleSortBlock
     ClassHierarchies::ProhibitAutoloading
     ClassHierarchies::ProhibitAutoloading