* version-nr: update to 1.6.5

* doc/Makefile.in: install THANKS
* TODO: remove items that have been done
* lib/showcright.c: exit(0) after showing the copyright since we don't exec cat anymore
* main/configure.c: add NULL to execlp() parameters; this fixes the random segfaults when showing the conffile-diff

ChangeLog

@@ -1,9 +1,21 @@
+Fri Dec 24 17:34:30 CET 1999 Wichert Akkerman <wakkerma@debian.org>
+
+  * version-nr: update to 1.6.5
+  * doc/Makefile.in: install THANKS
+  * TODO: remove items that have been done
+  * lib/showcright.c: exit(0) after showing the copyright since
+    we don't exec cat anymore
+  * Patch from David Huggins-Daines <dhd@eradicator.org>:
+    + main/configure.c: add NULL to execlp() parameters; this fixes the random
+      segfaults when showing the conffile-diff
+
 Fri Dec 24 15:35:29 CET 1999 Wichert Akkerman <wakkerma@debian.org>
 
   * debian/control: add Build-Depends
   * THANKS: new file which lists everyone who contributed to the code
   * Change `Debian Linux' to `Debian GNU/Linux' in a couple of manpages
   * main/enquiry.c: modify list1package to use the full width of the tty
+  * main/main.c: fix wrong call to fputs
   * Merge patches from Adam Heath:
     + lib/mlib.c: new function do_fd_copy to read a file into a fd
     + dpkg-deb/build.c: use do_fd_copy
@@ -25,7 +37,7 @@ Wed Dec 22 12:07:40 CET 1999 Wichert Akkerman <wakkerma@debian.org>
 
   * debian/dpkg-doc.postrm: Use doc-name instead of file-name (probably
     need to change the filename, but I'll be lazy now :)
-  * dselect/pkgdisplay.cc: Replace empty string for eflags to a space
+  * dselect/pkgdisplay.cc: Replace empty string for eflags with a space
     so gettext doesn't use the translation-info
   * po/update.sh: Generate dselect/helpmsgs.{cc,h} so we can translate them.
   * po/POTFILES.in: add dselect/helpmsgs.cc

THANKS

@@ -10,6 +10,7 @@ Christophe Le Bars <clebars@teaser.fr>
 Colin Plumb
 Dan Gohman <gohmandj@mrs.umn.edu>
 Darren Stalder <torin@daft.com>
+David Huggins-Daines <dhd@eradicator.org>
 Erick Branderhorst <branderhorst@heel.fgg.eur.nl>
 Galen Hazelwood <galenh@debian.org>
 Guy Maor <maor@debian.org>

TODO

@@ -4,7 +4,6 @@ urgent
  * Conflicts << installation ordering
  * Version numbers in pre-depends stuff
  * Search for all pre-depends things at once, bomb out if any not found
- * field overflow in dpkg --list
  * _always_ show section in --yet-to-unpack
  * automatically do --yet-to-unpack in installation methods
  * check depending packages when installing new version.
@@ -15,8 +14,6 @@ urgent
  * logging, both transcript logs (kept briefly)
    and action logs (kept forever?)  957
  * start-stop-daemon process status check. 1480
- * remove old docs from /usr/doc/dpkg.
- * WTA: fix translations for dpkg --help which broke after adding --stop-after
  * openpgp signatures in the package archive
 
 other stuff unlikely to get done soon
@@ -30,7 +27,8 @@ other stuff unlikely to get done soon
    (when running dpkg -i)? Keeps it from being listed as obsolete, and maybe
    from being considered for auto-upgrades (apt-get needs to know about this
    too)
- * Filename field generated by --record-avail handle split packages somehow.
+ * Filename field generated by --record-avail 
+ * handle split packages somehow.
  * understand Replaces in dselect
  * provide way for package to declare ownership of files for dpkg -S
    and -L without having dpkg act on this (.psuedolist?)
@@ -41,7 +39,6 @@ other stuff unlikely to get done soon
  * local conffiles, aswell as local files that dpkg should check before
    overwriting
  * hooks
- * gzip -0 option for dpkg-deb (probably easier to add a -z# option)
  * There is no documentation. 1526
  * newbie interface to dselect. 1037
  * dselect per-half focus and keybindings improvements. 1555

debian/changelog

@@ -9,6 +9,8 @@ dpkg (1.6.5) unstable; urgency=low
   * Use full width of tty in packagelisting, Closes: Bug# 53395
   * Add -z option to dpkg-deb to set compressionlevel when building
     packages, Closes: Bug# 53398
+  * Fix segfaults when producing a diff between current and new conffile,
+    Closes: Bug# 52197
 
  -- Wichert Akkerman <wakkerma@debian.org>  UNRELEASED
 
@@ -22,7 +24,7 @@ dpkg (1.6.4) unstable; urgency=low
   * Fix architecture-detection in dpkg-gencontrol, Closes: Bug#52616
   * Accept single-number values in update-rc.d, Closes: Bug#46810
 
- -- Wichert Akkerman <wakkerma@debian.org>  UNRELEASED
+ -- Wichert Akkerman <wakkerma@debian.org>  Sun, 19 Dec 1999 16:27:48 +0100
 
 dpkg (1.6.3) unstable; urgency=high
 

doc/Makefile.in

@@ -39,7 +39,7 @@ install-doc: install-doc-recursive
 		$(INSTALL_DATA) $$i $(DESTDIR)$(docdir)/internals/$$bn ; \
 	done
 	$(INSTALL_DATA) $(srcdir)/ChangeLog $(DESTDIR)$(docdir)/ChangeLog.manuals
-	set -e ; for i in ChangeLog TODO ; do \
+	set -e ; for i in ChangeLog THANKS TODO ; do \
 		$(INSTALL_DATA) $(top_srcdir)/$$i $(DESTDIR)$(docdir) ; \
 	done
 	$(INSTALL_DATA) $(top_srcdir)/COPYING $(DESTDIR)$(copyingfile)

dpkg-deb/main.c

@@ -80,7 +80,7 @@ const char printforhelp[]=
      "Type dpkg --help for help about installing and deinstalling packages.");
 
 int debugflag=0, nocheckflag=0, oldformatflag=BUILDOLDPKGFORMAT;
-const char* compression=NULL;
+char* compression=NULL;
 const struct cmdinfo *cipaction=0;
 dofunction *action=0;
 

lib/showcright.c

@@ -30,4 +30,5 @@ void showcopyright(const struct cmdinfo *c, const char *v) {
   fd= open(COPYINGFILE,O_RDONLY);
   if (fd < 0) ohshite(_("cannot open GPL file " COPYINGFILE));
   do_fd_copy(fd, 1, _("showcopyright"));
+  exit(0);
 }

main/configure.c

@@ -319,7 +319,7 @@ void deferred_configure(struct pkginfo *pkg) {
 	      sprintf(cmdbuf, "diff -u %.250s %.250s | %.250s", cdr.buf, cdr2.buf, p);
               s= getenv(SHELLENV);
               if (!s || !*s) s= DEFAULTSHELL;
-	      execlp(s,s,"-c", cmdbuf);
+	      execlp(s,s,"-c", cmdbuf, NULL);
               ohshite(_("failed to run diff (%.250s)"), cmdbuf);
 	    }
             while ((r= waitpid(c1,&status,0)) == -1 && errno == EINTR);

version-nr

@@ -1 +1 @@
-1.6.4
+1.6.5