Преглед изворни кода

dpkg-gensymbols: fail when empty values are given to -v, -P or -e.

* scripts/dpkg-gensymbols.pl: Do not accept empty parameters for
-v, -P and -e. "-v" led to empty versions in symbols files and people used
that option by mistake believing it would enable a verbose mode.
Raphael Hertzog пре 18 година
родитељ
комит
0b735b963d
3 измењених фајлова са 10 додато и 3 уклоњено
  1. 5 0
      ChangeLog
  2. 2 0
      debian/changelog
  3. 3 3
      scripts/dpkg-gensymbols.pl

+ 5 - 0
ChangeLog

@@ -1,3 +1,8 @@
+2008-05-05  Raphael Hertzog  <hertzog@debian.org>
+
+	* scripts/dpkg-gensymbols.pl: Do not accept empty parameters for
+	-v,  -P and -e.
+
 2008-05-05  Raphael Hertzog  <hertzog@debian.org>
 
 	* scripts/dpkg-shlibdeps.pl: Include the format of the desired

+ 2 - 0
debian/changelog

@@ -7,6 +7,8 @@ dpkg (1.15.0) UNRELEASED; urgency=low
   [ Raphael Hertzog ]
   * Enhance dpkg-shlibdeps's error message when a library can't be found to
     include the ELF format of the desired library. Closes: #474671
+  * dpkg-gensymbols now refuses empty values for the the -v -P and -e
+    parameters.
 
   [ Updated dpkg translations ]
   * Portuguese (Miguel Figueiredo).

+ 3 - 3
scripts/dpkg-gensymbols.pl

@@ -74,9 +74,9 @@ while (@ARGV) {
 	$compare = defined($1) ? $1 : 1;
     } elsif (m/^-d$/) {
 	$debug = 1;
-    } elsif (m/^-v(.*)/) {
+    } elsif (m/^-v(.+)$/) {
 	$sourceversion = $1;
-    } elsif (m/^-e(.*)/) {
+    } elsif (m/^-e(.+)$/) {
 	my $file = $1;
 	if (-e $file) {
 	    push @files, $file;
@@ -85,7 +85,7 @@ while (@ARGV) {
 	}
     } elsif (m/^-p(.*)/) {
 	error(_g("Illegal package name \`%s'"), $1);
-    } elsif (m/^-P(.*)$/) {
+    } elsif (m/^-P(.+)$/) {
 	$packagebuilddir = $1;
 	$packagebuilddir =~ s{/+$}{};
     } elsif (m/^-O$/) {