Explorar o código

Do not buffer writes larger than the buffer if possible

It makes no sense to split a large block into multiple small
blocks, so when we have the chance to write them unbuffered,
do so.
Julian Andres Klode %!s(int64=10) %!d(string=hai) anos
pai
achega
f1828e6b0a
Modificáronse 1 ficheiros con 6 adicións e 0 borrados
  1. 6 0
      apt-pkg/contrib/fileutl.cc

+ 6 - 0
apt-pkg/contrib/fileutl.cc

@@ -1260,6 +1260,12 @@ public:
    }
    virtual ssize_t InternalWrite(void const * const From, unsigned long long const Size) override
    {
+      // Optimisation: If the buffer is empty and we have more to write than
+      // would fit in the buffer (or equal number of bytes), write directly.
+      if (writebuffer.empty() == true && Size >= writebuffer.free())
+	 return wrapped->InternalWrite(From, Size);
+
+      // Write as much into the buffer as possible and then flush if needed
       auto written = writebuffer.write(From, Size);
 
       if (writebuffer.full() && InternalFlush() == false)