Explorar el Código

fix apt output ordering and update test to match the new human friendly messages that include the architecture

Michael Vogt hace 12 años
padre
commit
d274520ee8
Se han modificado 2 ficheros con 7 adiciones y 7 borrados
  1. 5 5
      apt-pkg/deb/dpkgpm.cc
  2. 2 2
      test/integration/test-apt-progress-fd

+ 5 - 5
apt-pkg/deb/dpkgpm.cc

@@ -668,14 +668,15 @@ void pkgDPkgPM::ProcessDpkgStatusLine(char *line)
       // check if the package moved to the next dpkg state
       if(next_action && (action == next_action))
       {
-         // we moved from one dpkg state to a new one, report that
-         PackageOpsDone[pkg]++;
-         PackagesDone++;
-
          // only read the translation if there is actually a next
          // action
          const char *translation = _(states[PackageOpsDone[pkg]].str);
          std::string msg;
+
+         // we moved from one dpkg state to a new one, report that
+         PackageOpsDone[pkg]++;
+         PackagesDone++;
+
          strprintf(msg, translation, i18n_pkgname.c_str());
          d->progress->StatusChanged(pkgname, PackagesDone, PackagesTotal, msg);
          
@@ -1505,7 +1506,6 @@ bool pkgDPkgPM::Go(APT::Progress::PackageManager *progress)
    CloseLog();
 
    // dpkg is done at this point
-   d->progress->StatusChanged("", PackagesDone, PackagesTotal, "");
    d->progress->Stop();
 
    if (pkgPackageManager::SigINTStop)

+ 2 - 2
test/integration/test-apt-progress-fd

@@ -21,7 +21,7 @@ pmstatus:dpkg-exec:0:Running dpkg
 pmstatus:testing:0:Installing testing (amd64)
 pmstatus:testing:20:Preparing testing (amd64)
 pmstatus:testing:40:Unpacking testing (amd64)
-pmstatus:testing:60:Preparing to configure testing
+pmstatus:testing:60:Preparing to configure testing (amd64)
 pmstatus:dpkg-exec:60:Running dpkg
 pmstatus:testing:60:Configuring testing (amd64)
 pmstatus:testing:80:Configuring testing (amd64)
@@ -35,7 +35,7 @@ dlstatus:1:0:Retrieving file 1 of 1
 pmstatus:dpkg-exec:0:Running dpkg
 pmstatus:testing:20:Preparing testing (amd64)
 pmstatus:testing:40:Unpacking testing (amd64)
-pmstatus:testing:60:Preparing to configure testing
+pmstatus:testing:60:Preparing to configure testing (amd64)
 pmstatus:dpkg-exec:60:Running dpkg
 pmstatus:testing:60:Configuring testing (amd64)
 pmstatus:testing:80:Configuring testing (amd64)