Просмотр исходного кода

warning: no previous declaration for foobar() [-Wmissing-declarations]

Git-Dch: Ignore
Reported-By: gcc -Wmissing-declarations
David Kalnischkies лет назад: 12
Родитель
Сommit
c3ccac9232

+ 1 - 1
apt-pkg/depcache.cc

@@ -889,7 +889,7 @@ bool pkgDepCache::IsDeleteOkProtectInstallRequests(PkgIterator const &Pkg,
    and prevents mode changes for packages on hold for example.
    and prevents mode changes for packages on hold for example.
    If you want to check Mode specific stuff you can use the virtual public
    If you want to check Mode specific stuff you can use the virtual public
    Is<Mode>Ok methods instead */
    Is<Mode>Ok methods instead */
-char const* PrintMode(char const mode)
+static char const* PrintMode(char const mode)
 {
 {
 	 switch (mode)
 	 switch (mode)
 	 {
 	 {

+ 7 - 7
apt-private/private-cmndline.cc

@@ -14,7 +14,7 @@
 #include <apti18n.h>
 #include <apti18n.h>
 									/*}}}*/
 									/*}}}*/
 
 
-bool strcmp_match_in_list(char const * const Cmd, ...)			/*{{{*/
+static bool strcmp_match_in_list(char const * const Cmd, ...)		/*{{{*/
 {
 {
    va_list args;
    va_list args;
    bool found = false;
    bool found = false;
@@ -33,7 +33,7 @@ bool strcmp_match_in_list(char const * const Cmd, ...)			/*{{{*/
 									/*}}}*/
 									/*}}}*/
 #define addArg(w,x,y,z) Args.push_back(CommandLine::MakeArgs(w,x,y,z))
 #define addArg(w,x,y,z) Args.push_back(CommandLine::MakeArgs(w,x,y,z))
 #define CmdMatches(...) strcmp_match_in_list(Cmd, __VA_ARGS__, NULL)
 #define CmdMatches(...) strcmp_match_in_list(Cmd, __VA_ARGS__, NULL)
-bool addArgumentsAPTCache(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
+static bool addArgumentsAPTCache(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
 {
 {
    if (CmdMatches("depends", "rdepends", "xvcg", "dotty"))
    if (CmdMatches("depends", "rdepends", "xvcg", "dotty"))
    {
    {
@@ -82,7 +82,7 @@ bool addArgumentsAPTCache(std::vector<CommandLine::Args> &Args, char const * con
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool addArgumentsAPTCDROM(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
+static bool addArgumentsAPTCDROM(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
 {
 {
    if (CmdMatches("add", "ident") == false)
    if (CmdMatches("add", "ident") == false)
       return false;
       return false;
@@ -100,7 +100,7 @@ bool addArgumentsAPTCDROM(std::vector<CommandLine::Args> &Args, char const * con
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool addArgumentsAPTConfig(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
+static bool addArgumentsAPTConfig(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
 {
 {
    if (CmdMatches("dump"))
    if (CmdMatches("dump"))
    {
    {
@@ -115,7 +115,7 @@ bool addArgumentsAPTConfig(std::vector<CommandLine::Args> &Args, char const * co
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool addArgumentsAPTGet(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
+static bool addArgumentsAPTGet(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
 {
 {
    if (CmdMatches("install", "remove", "purge", "upgrade", "dist-upgrade",
    if (CmdMatches("install", "remove", "purge", "upgrade", "dist-upgrade",
 	    "dselect-upgrade", "autoremove"))
 	    "dselect-upgrade", "autoremove"))
@@ -202,7 +202,7 @@ bool addArgumentsAPTGet(std::vector<CommandLine::Args> &Args, char const * const
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool addArgumentsAPTMark(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
+static bool addArgumentsAPTMark(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
 {
 {
    if (CmdMatches("auto", "manual", "hold", "unhold", "showauto",
    if (CmdMatches("auto", "manual", "hold", "unhold", "showauto",
 	    "showmanual", "showhold", "showholds", "install",
 	    "showmanual", "showhold", "showholds", "install",
@@ -222,7 +222,7 @@ bool addArgumentsAPTMark(std::vector<CommandLine::Args> &Args, char const * cons
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool addArgumentsAPT(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
+static bool addArgumentsAPT(std::vector<CommandLine::Args> &Args, char const * const Cmd)/*{{{*/
 {
 {
    if (CmdMatches("list"))
    if (CmdMatches("list"))
    {
    {

+ 1 - 0
apt-private/private-download.cc

@@ -8,6 +8,7 @@
 #include <apt-pkg/strutl.h>
 #include <apt-pkg/strutl.h>
 
 
 #include "private-output.h"
 #include "private-output.h"
+#include "private-download.h"
 
 
 #include <locale.h>
 #include <locale.h>
 
 

+ 1 - 1
apt-private/private-install.cc

@@ -386,7 +386,7 @@ bool InstallPackages(CacheFile &Cache,bool ShwKept,bool Ask, bool Safety)
 // DoAutomaticRemove - Remove all automatic unused packages		/*{{{*/
 // DoAutomaticRemove - Remove all automatic unused packages		/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* Remove unused automatic packages */
 /* Remove unused automatic packages */
-bool DoAutomaticRemove(CacheFile &Cache)
+static bool DoAutomaticRemove(CacheFile &Cache)
 {
 {
    bool Debug = _config->FindI("Debug::pkgAutoRemove",false);
    bool Debug = _config->FindI("Debug::pkgAutoRemove",false);
    bool doAutoRemove = _config->FindB("APT::Get::AutomaticRemove", false);
    bool doAutoRemove = _config->FindB("APT::Get::AutomaticRemove", false);

+ 1 - 1
apt-private/private-list.cc

@@ -99,7 +99,7 @@ private:
    #undef PackageMatcher
    #undef PackageMatcher
 };
 };
 									/*}}}*/
 									/*}}}*/
-void ListAllVersions(pkgCacheFile &CacheFile, pkgRecords &records,	/*{{{*/
+static void ListAllVersions(pkgCacheFile &CacheFile, pkgRecords &records,/*{{{*/
                      pkgCache::PkgIterator P,    
                      pkgCache::PkgIterator P,    
                      std::ostream &outs,
                      std::ostream &outs,
                      bool include_summary=true)
                      bool include_summary=true)

+ 2 - 2
apt-private/private-moo.cc

@@ -22,7 +22,7 @@
 #include <apti18n.h>
 #include <apti18n.h>
 									/*}}}*/
 									/*}}}*/
 
 
-std::string getMooLine() {						/*{{{*/
+static std::string getMooLine() {					/*{{{*/
    time_t const timenow = time(NULL);
    time_t const timenow = time(NULL);
    struct tm special;
    struct tm special;
    localtime_r(&timenow, &special);
    localtime_r(&timenow, &special);
@@ -60,7 +60,7 @@ std::string getMooLine() {						/*{{{*/
    return out.str();
    return out.str();
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool printMooLine() {							/*{{{*/
+static bool printMooLine() {						/*{{{*/
    std::cerr << getMooLine() << std::endl;
    std::cerr << getMooLine() << std::endl;
    return true;
    return true;
 }
 }

+ 8 - 8
apt-private/private-output.cc

@@ -63,7 +63,7 @@ bool InitOutput()							/*{{{*/
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetArchiveSuite(pkgCacheFile &CacheFile, pkgCache::VerIterator ver) /*{{{*/
+static std::string GetArchiveSuite(pkgCacheFile &CacheFile, pkgCache::VerIterator ver) /*{{{*/
 {
 {
    std::string suite = "";
    std::string suite = "";
    if (ver && ver.FileList() && ver.FileList())
    if (ver && ver.FileList() && ver.FileList())
@@ -82,7 +82,7 @@ std::string GetArchiveSuite(pkgCacheFile &CacheFile, pkgCache::VerIterator ver)
    return suite;
    return suite;
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetFlagsStr(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
+static std::string GetFlagsStr(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
 {
 {
    pkgDepCache *DepCache = CacheFile.GetDepCache();
    pkgDepCache *DepCache = CacheFile.GetDepCache();
    pkgDepCache::StateCache &state = (*DepCache)[P];
    pkgDepCache::StateCache &state = (*DepCache)[P];
@@ -99,7 +99,7 @@ std::string GetFlagsStr(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
    return flags_str;
    return flags_str;
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetCandidateVersion(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
+static std::string GetCandidateVersion(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
 {
 {
    pkgPolicy *policy = CacheFile.GetPolicy();
    pkgPolicy *policy = CacheFile.GetPolicy();
    pkgCache::VerIterator cand = policy->GetCandidateVer(P);
    pkgCache::VerIterator cand = policy->GetCandidateVer(P);
@@ -107,14 +107,14 @@ std::string GetCandidateVersion(pkgCacheFile &CacheFile, pkgCache::PkgIterator P
    return cand ? cand.VerStr() : "(none)";
    return cand ? cand.VerStr() : "(none)";
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetInstalledVersion(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
+static std::string GetInstalledVersion(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
 {
 {
    pkgCache::VerIterator inst = P.CurrentVer();
    pkgCache::VerIterator inst = P.CurrentVer();
 
 
    return inst ? inst.VerStr() : "(none)";
    return inst ? inst.VerStr() : "(none)";
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetVersion(pkgCacheFile &CacheFile, pkgCache::VerIterator V)/*{{{*/
+static std::string GetVersion(pkgCacheFile &CacheFile, pkgCache::VerIterator V)/*{{{*/
 {
 {
    pkgCache::PkgIterator P = V.ParentPkg();
    pkgCache::PkgIterator P = V.ParentPkg();
    if (V == P.CurrentVer())
    if (V == P.CurrentVer())
@@ -134,16 +134,16 @@ std::string GetVersion(pkgCacheFile &CacheFile, pkgCache::VerIterator V)/*{{{*/
    return "(none)";
    return "(none)";
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetArchitecture(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
+static std::string GetArchitecture(pkgCacheFile &CacheFile, pkgCache::PkgIterator P)/*{{{*/
 {
 {
    pkgPolicy *policy = CacheFile.GetPolicy();
    pkgPolicy *policy = CacheFile.GetPolicy();
    pkgCache::VerIterator inst = P.CurrentVer();
    pkgCache::VerIterator inst = P.CurrentVer();
    pkgCache::VerIterator cand = policy->GetCandidateVer(P);
    pkgCache::VerIterator cand = policy->GetCandidateVer(P);
-   
+
    return inst ? inst.Arch() : cand.Arch();
    return inst ? inst.Arch() : cand.Arch();
 }
 }
 									/*}}}*/
 									/*}}}*/
-std::string GetShortDescription(pkgCacheFile &CacheFile, pkgRecords &records, pkgCache::PkgIterator P)/*{{{*/
+static std::string GetShortDescription(pkgCacheFile &CacheFile, pkgRecords &records, pkgCache::PkgIterator P)/*{{{*/
 {
 {
    pkgPolicy *policy = CacheFile.GetPolicy();
    pkgPolicy *policy = CacheFile.GetPolicy();
 
 

+ 2 - 1
apt-private/private-show.cc

@@ -24,6 +24,7 @@
 
 
 #include "private-output.h"
 #include "private-output.h"
 #include "private-cacheset.h"
 #include "private-cacheset.h"
+#include "private-show.h"
 									/*}}}*/
 									/*}}}*/
 
 
 namespace APT {
 namespace APT {
@@ -31,7 +32,7 @@ namespace APT {
 
 
 // DisplayRecord - Displays the complete record for the package		/*{{{*/
 // DisplayRecord - Displays the complete record for the package		/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
-bool DisplayRecord(pkgCacheFile &CacheFile, pkgCache::VerIterator V,
+static bool DisplayRecord(pkgCacheFile &CacheFile, pkgCache::VerIterator V,
                    ostream &out)
                    ostream &out)
 {
 {
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();

+ 1 - 0
apt-private/private-update.cc

@@ -31,6 +31,7 @@
 
 
 #include "private-cachefile.h"
 #include "private-cachefile.h"
 #include "private-output.h"
 #include "private-output.h"
+#include "private-update.h"
 #include "acqprogress.h"
 #include "acqprogress.h"
 
 
 #include <apti18n.h>
 #include <apti18n.h>

+ 24 - 24
cmdline/apt-cache.cc

@@ -58,7 +58,7 @@ using namespace std;
 // LocalitySort - Sort a version list by package file locality		/*{{{*/
 // LocalitySort - Sort a version list by package file locality		/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-int LocalityCompare(const void *a, const void *b)
+static int LocalityCompare(const void *a, const void *b)
 {
 {
    pkgCache::VerFile *A = *(pkgCache::VerFile **)a;
    pkgCache::VerFile *A = *(pkgCache::VerFile **)a;
    pkgCache::VerFile *B = *(pkgCache::VerFile **)b;
    pkgCache::VerFile *B = *(pkgCache::VerFile **)b;
@@ -75,13 +75,13 @@ int LocalityCompare(const void *a, const void *b)
    return A->File - B->File;
    return A->File - B->File;
 }
 }
 
 
-void LocalitySort(pkgCache::VerFile **begin,
+static void LocalitySort(pkgCache::VerFile **begin,
 		  unsigned long Count,size_t Size)
 		  unsigned long Count,size_t Size)
 {   
 {   
    qsort(begin,Count,Size,LocalityCompare);
    qsort(begin,Count,Size,LocalityCompare);
 }
 }
 
 
-void LocalitySort(pkgCache::DescFile **begin,
+static void LocalitySort(pkgCache::DescFile **begin,
 		  unsigned long Count,size_t Size)
 		  unsigned long Count,size_t Size)
 {   
 {   
    qsort(begin,Count,Size,LocalityCompare);
    qsort(begin,Count,Size,LocalityCompare);
@@ -90,7 +90,7 @@ void LocalitySort(pkgCache::DescFile **begin,
 // UnMet - Show unmet dependencies					/*{{{*/
 // UnMet - Show unmet dependencies					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowUnMet(pkgCache::VerIterator const &V, bool const Important)
+static bool ShowUnMet(pkgCache::VerIterator const &V, bool const Important)
 {
 {
 	 bool Header = false;
 	 bool Header = false;
 	 for (pkgCache::DepIterator D = V.DependsList(); D.end() == false;)
 	 for (pkgCache::DepIterator D = V.DependsList(); D.end() == false;)
@@ -163,7 +163,7 @@ bool ShowUnMet(pkgCache::VerIterator const &V, bool const Important)
 	 }
 	 }
    return true;
    return true;
 }
 }
-bool UnMet(CommandLine &CmdL)
+static bool UnMet(CommandLine &CmdL)
 {
 {
    bool const Important = _config->FindB("APT::Cache::Important",false);
    bool const Important = _config->FindB("APT::Cache::Important",false);
 
 
@@ -193,7 +193,7 @@ bool UnMet(CommandLine &CmdL)
 // DumpPackage - Show a dump of a package record			/*{{{*/
 // DumpPackage - Show a dump of a package record			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool DumpPackage(CommandLine &CmdL)
+static bool DumpPackage(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    APT::CacheSetHelper helper(true, GlobalError::NOTICE);
    APT::CacheSetHelper helper(true, GlobalError::NOTICE);
@@ -258,7 +258,7 @@ bool DumpPackage(CommandLine &CmdL)
 // Stats - Dump some nice statistics					/*{{{*/
 // Stats - Dump some nice statistics					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Stats(CommandLine &Cmd)
+static bool Stats(CommandLine &Cmd)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -371,7 +371,7 @@ bool Stats(CommandLine &Cmd)
 // Dump - show everything						/*{{{*/
 // Dump - show everything						/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This is worthless except fer debugging things */
 /* This is worthless except fer debugging things */
-bool Dump(CommandLine &Cmd)
+static bool Dump(CommandLine &Cmd)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -423,7 +423,7 @@ bool Dump(CommandLine &Cmd)
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This is needed to make dpkg --merge happy.. I spent a bit of time to 
 /* This is needed to make dpkg --merge happy.. I spent a bit of time to 
    make this run really fast, perhaps I went a little overboard.. */
    make this run really fast, perhaps I went a little overboard.. */
-bool DumpAvail(CommandLine &Cmd)
+static bool DumpAvail(CommandLine &Cmd)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -562,7 +562,7 @@ bool DumpAvail(CommandLine &Cmd)
 }
 }
 									/*}}}*/
 									/*}}}*/
 // ShowDepends - Helper for printing out a dependency tree		/*{{{*/
 // ShowDepends - Helper for printing out a dependency tree		/*{{{*/
-bool ShowDepends(CommandLine &CmdL, bool const RevDepends)
+static bool ShowDepends(CommandLine &CmdL, bool const RevDepends)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -676,7 +676,7 @@ bool ShowDepends(CommandLine &CmdL, bool const RevDepends)
 // Depends - Print out a dependency tree				/*{{{*/
 // Depends - Print out a dependency tree				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Depends(CommandLine &CmdL)
+static bool Depends(CommandLine &CmdL)
 {
 {
    return ShowDepends(CmdL, false);
    return ShowDepends(CmdL, false);
 }
 }
@@ -684,7 +684,7 @@ bool Depends(CommandLine &CmdL)
 // RDepends - Print out a reverse dependency tree			/*{{{*/
 // RDepends - Print out a reverse dependency tree			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool RDepends(CommandLine &CmdL)
+static bool RDepends(CommandLine &CmdL)
 {
 {
    return ShowDepends(CmdL, true);
    return ShowDepends(CmdL, true);
 }
 }
@@ -693,7 +693,7 @@ bool RDepends(CommandLine &CmdL)
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 // Code contributed from Junichi Uekawa <dancer@debian.org> on 20 June 2002.
 // Code contributed from Junichi Uekawa <dancer@debian.org> on 20 June 2002.
 
 
-bool XVcg(CommandLine &CmdL)
+static bool XVcg(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -905,7 +905,7 @@ bool XVcg(CommandLine &CmdL)
 /* Dotty is the graphvis program for generating graphs. It is a fairly
 /* Dotty is the graphvis program for generating graphs. It is a fairly
    simple queuing algorithm that just writes dependencies and nodes. 
    simple queuing algorithm that just writes dependencies and nodes. 
    http://www.research.att.com/sw/tools/graphviz/ */
    http://www.research.att.com/sw/tools/graphviz/ */
-bool Dotty(CommandLine &CmdL)
+static bool Dotty(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -1126,7 +1126,7 @@ static unsigned char const* skipDescriptionFields(unsigned char const * DescP)
       ++DescP;
       ++DescP;
    return DescP;
    return DescP;
 }
 }
-bool DisplayRecord(pkgCacheFile &CacheFile, pkgCache::VerIterator V)
+static bool DisplayRecord(pkgCacheFile &CacheFile, pkgCache::VerIterator V)
 {
 {
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
    if (unlikely(Cache == NULL))
    if (unlikely(Cache == NULL))
@@ -1228,7 +1228,7 @@ struct ExDescFile
 // Search - Perform a search						/*{{{*/
 // Search - Perform a search						/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This searches the package names and package descriptions for a pattern */
 /* This searches the package names and package descriptions for a pattern */
-bool Search(CommandLine &CmdL)
+static bool Search(CommandLine &CmdL)
 {
 {
    bool const ShowFull = _config->FindB("APT::Cache::ShowFull",false);
    bool const ShowFull = _config->FindB("APT::Cache::ShowFull",false);
    bool const NamesOnly = _config->FindB("APT::Cache::NamesOnly",false);
    bool const NamesOnly = _config->FindB("APT::Cache::NamesOnly",false);
@@ -1388,7 +1388,7 @@ bool Search(CommandLine &CmdL)
 }
 }
 									/*}}}*/
 									/*}}}*/
 /* ShowAuto - show automatically installed packages (sorted)		{{{*/
 /* ShowAuto - show automatically installed packages (sorted)		{{{*/
-bool ShowAuto(CommandLine &CmdL)
+static bool ShowAuto(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -1415,7 +1415,7 @@ bool ShowAuto(CommandLine &CmdL)
 // ShowPackage - Dump the package record to the screen			/*{{{*/
 // ShowPackage - Dump the package record to the screen			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowPackage(CommandLine &CmdL)
+static bool ShowPackage(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    CacheSetHelperVirtuals helper(true, GlobalError::NOTICE);
    CacheSetHelperVirtuals helper(true, GlobalError::NOTICE);
@@ -1439,7 +1439,7 @@ bool ShowPackage(CommandLine &CmdL)
 // ShowPkgNames - Show package names					/*{{{*/
 // ShowPkgNames - Show package names					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This does a prefix match on the first argument */
 /* This does a prefix match on the first argument */
-bool ShowPkgNames(CommandLine &CmdL)
+static bool ShowPkgNames(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    if (unlikely(CacheFile.BuildCaches(NULL, false) == false))
    if (unlikely(CacheFile.BuildCaches(NULL, false) == false))
@@ -1478,7 +1478,7 @@ bool ShowPkgNames(CommandLine &CmdL)
 // ShowSrcPackage - Show source package records				/*{{{*/
 // ShowSrcPackage - Show source package records				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowSrcPackage(CommandLine &CmdL)
+static bool ShowSrcPackage(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgSourceList *List = CacheFile.GetSourceList();
    pkgSourceList *List = CacheFile.GetSourceList();
@@ -1515,7 +1515,7 @@ bool ShowSrcPackage(CommandLine &CmdL)
 // Policy - Show the results of the preferences file			/*{{{*/
 // Policy - Show the results of the preferences file			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Policy(CommandLine &CmdL)
+static bool Policy(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -1644,7 +1644,7 @@ bool Policy(CommandLine &CmdL)
 // Madison - Look a bit like katie's madison				/*{{{*/
 // Madison - Look a bit like katie's madison				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Madison(CommandLine &CmdL)
+static bool Madison(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgSourceList *SrcList = CacheFile.GetSourceList();
    pkgSourceList *SrcList = CacheFile.GetSourceList();
@@ -1717,7 +1717,7 @@ bool Madison(CommandLine &CmdL)
 // GenCaches - Call the main cache generator				/*{{{*/
 // GenCaches - Call the main cache generator				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool GenCaches(CommandLine &Cmd)
+static bool GenCaches(CommandLine &Cmd)
 {
 {
    OpTextProgress Progress(*_config);
    OpTextProgress Progress(*_config);
 
 
@@ -1728,7 +1728,7 @@ bool GenCaches(CommandLine &Cmd)
 // ShowHelp - Show a help screen					/*{{{*/
 // ShowHelp - Show a help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &Cmd)
+static bool ShowHelp(CommandLine &Cmd)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 4 - 4
cmdline/apt-cdrom.cc

@@ -111,7 +111,7 @@ OpProgress* pkgCdromTextStatus::GetOpProgress()
 }
 }
 									/*}}}*/
 									/*}}}*/
 // SetupAutoDetect       						/*{{{*/
 // SetupAutoDetect       						/*{{{*/
-bool AutoDetectCdrom(pkgUdevCdromDevices &UdevCdroms, unsigned int &i, bool &automounted)
+static bool AutoDetectCdrom(pkgUdevCdromDevices &UdevCdroms, unsigned int &i, bool &automounted)
 {
 {
    bool Debug =  _config->FindB("Debug::Acquire::cdrom", false);
    bool Debug =  _config->FindB("Debug::Acquire::cdrom", false);
 
 
@@ -155,7 +155,7 @@ bool AutoDetectCdrom(pkgUdevCdromDevices &UdevCdroms, unsigned int &i, bool &aut
    sequence is to mount/umount the CD, Ident it then scan it for package 
    sequence is to mount/umount the CD, Ident it then scan it for package 
    files and reduce that list. Then we copy over the package files and
    files and reduce that list. Then we copy over the package files and
    verify them. Then rewrite the database files */
    verify them. Then rewrite the database files */
-bool DoAdd(CommandLine &)
+static bool DoAdd(CommandLine &)
 {
 {
    pkgUdevCdromDevices UdevCdroms;
    pkgUdevCdromDevices UdevCdroms;
    pkgCdromTextStatus log;
    pkgCdromTextStatus log;
@@ -201,7 +201,7 @@ bool DoAdd(CommandLine &)
 // DoIdent - Ident a CDROM						/*{{{*/
 // DoIdent - Ident a CDROM						/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool DoIdent(CommandLine &)
+static bool DoIdent(CommandLine &)
 {
 {
    pkgUdevCdromDevices UdevCdroms;
    pkgUdevCdromDevices UdevCdroms;
    string ident;
    string ident;
@@ -247,7 +247,7 @@ bool DoIdent(CommandLine &)
 // ShowHelp - Show the help screen					/*{{{*/
 // ShowHelp - Show the help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &)
+static bool ShowHelp(CommandLine &)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 3 - 3
cmdline/apt-config.cc

@@ -40,7 +40,7 @@ using namespace std;
 // DoShell - Handle the shell command					/*{{{*/
 // DoShell - Handle the shell command					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool DoShell(CommandLine &CmdL)
+static bool DoShell(CommandLine &CmdL)
 {
 {
    for (const char **I = CmdL.FileList + 1; *I != 0; I += 2)
    for (const char **I = CmdL.FileList + 1; *I != 0; I += 2)
    {
    {
@@ -63,7 +63,7 @@ bool DoShell(CommandLine &CmdL)
 // DoDump - Dump the configuration space				/*{{{*/
 // DoDump - Dump the configuration space				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool DoDump(CommandLine &CmdL)
+static bool DoDump(CommandLine &CmdL)
 {
 {
    bool const empty = _config->FindB("APT::Config::Dump::EmptyValue", true);
    bool const empty = _config->FindB("APT::Config::Dump::EmptyValue", true);
    std::string const format = _config->Find("APT::Config::Dump::Format", "%f \"%v\";\n");
    std::string const format = _config->Find("APT::Config::Dump::Format", "%f \"%v\";\n");
@@ -78,7 +78,7 @@ bool DoDump(CommandLine &CmdL)
 // ShowHelp - Show the help screen					/*{{{*/
 // ShowHelp - Show the help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &CmdL)
+static bool ShowHelp(CommandLine &CmdL)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 1 - 1
cmdline/apt-dump-solver.cc

@@ -18,7 +18,7 @@
 // ShowHelp - Show a help screen					/*{{{*/
 // ShowHelp - Show a help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp() {
+static bool ShowHelp() {
 
 
 	std::cout <<
 	std::cout <<
 		PACKAGE " " PACKAGE_VERSION " for " COMMON_ARCH " compiled on " __DATE__ " " __TIME__ << std::endl <<
 		PACKAGE " " PACKAGE_VERSION " for " COMMON_ARCH " compiled on " __DATE__ " " __TIME__ << std::endl <<

+ 4 - 4
cmdline/apt-extracttemplates.cc

@@ -212,7 +212,7 @@ bool DebFile::ParseInfo()
 // ShowHelp - show a short help text					/*{{{*/
 // ShowHelp - show a short help text					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-int ShowHelp(void)
+static int ShowHelp(void)
 {
 {
    	ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    	ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);
@@ -237,7 +237,7 @@ int ShowHelp(void)
 // WriteFile - write the contents of the passed string to a file	/*{{{*/
 // WriteFile - write the contents of the passed string to a file	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-string WriteFile(const char *package, const char *prefix, const char *data)
+static string WriteFile(const char *package, const char *prefix, const char *data)
 {
 {
 	char fn[512];
 	char fn[512];
 	static int i;
 	static int i;
@@ -265,7 +265,7 @@ string WriteFile(const char *package, const char *prefix, const char *data)
 // WriteConfig - write out the config data from a debian package file	/*{{{*/
 // WriteConfig - write out the config data from a debian package file	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-void WriteConfig(const DebFile &file)
+static void WriteConfig(const DebFile &file)
 {
 {
 	string templatefile = WriteFile(file.Package.c_str(), "template", file.Template);
 	string templatefile = WriteFile(file.Package.c_str(), "template", file.Template);
 	string configscript = WriteFile(file.Package.c_str(), "config", file.Config);
 	string configscript = WriteFile(file.Package.c_str(), "config", file.Config);
@@ -279,7 +279,7 @@ void WriteConfig(const DebFile &file)
 // InitCache - initialize the package cache				/*{{{*/
 // InitCache - initialize the package cache				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Go(CommandLine &CmdL)
+static bool Go(CommandLine &CmdL)
 {	
 {	
 	// Initialize the apt cache
 	// Initialize the apt cache
 	MMap *Map = 0;
 	MMap *Map = 0;

+ 18 - 18
cmdline/apt-get.cc

@@ -97,7 +97,7 @@ using namespace std;
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This used to be inlined in DoInstall, but with the advent of regex package
 /* This used to be inlined in DoInstall, but with the advent of regex package
    name matching it was split out.. */
    name matching it was split out.. */
-bool TryToInstallBuildDep(pkgCache::PkgIterator Pkg,pkgCacheFile &Cache,
+static bool TryToInstallBuildDep(pkgCache::PkgIterator Pkg,pkgCacheFile &Cache,
 		  pkgProblemResolver &Fix,bool Remove,bool BrokenFix,
 		  pkgProblemResolver &Fix,bool Remove,bool BrokenFix,
 		  bool AllowFail = true)
 		  bool AllowFail = true)
 {
 {
@@ -138,7 +138,7 @@ bool TryToInstallBuildDep(pkgCache::PkgIterator Pkg,pkgCacheFile &Cache,
 
 
 // helper that can go wit hthe next ABI break
 // helper that can go wit hthe next ABI break
 #if (APT_PKG_MAJOR >= 4 && APT_PKG_MINOR < 13)
 #if (APT_PKG_MAJOR >= 4 && APT_PKG_MINOR < 13)
-std::string MetaIndexFileNameOnDisk(metaIndex *metaindex)
+static std::string MetaIndexFileNameOnDisk(metaIndex *metaindex)
 {
 {
    // FIXME: this cast is the horror, the horror
    // FIXME: this cast is the horror, the horror
    debReleaseIndex *r = (debReleaseIndex*)metaindex;
    debReleaseIndex *r = (debReleaseIndex*)metaindex;
@@ -159,7 +159,7 @@ std::string MetaIndexFileNameOnDisk(metaIndex *metaindex)
 // GetReleaseForSourceRecord - Return Suite for the given srcrecord	/*{{{*/
 // GetReleaseForSourceRecord - Return Suite for the given srcrecord	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-std::string GetReleaseForSourceRecord(pkgSourceList *SrcList,
+static std::string GetReleaseForSourceRecord(pkgSourceList *SrcList,
                                       pkgSrcRecords::Parser *Parse)
                                       pkgSrcRecords::Parser *Parse)
 {
 {
    // try to find release
    // try to find release
@@ -194,7 +194,7 @@ std::string GetReleaseForSourceRecord(pkgSourceList *SrcList,
 // FindSrc - Find a source record					/*{{{*/
 // FindSrc - Find a source record					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-pkgSrcRecords::Parser *FindSrc(const char *Name,pkgRecords &Recs,
+static pkgSrcRecords::Parser *FindSrc(const char *Name,pkgRecords &Recs,
 			       pkgSrcRecords &SrcRecs,string &Src,
 			       pkgSrcRecords &SrcRecs,string &Src,
 			       CacheFile &CacheFile)
 			       CacheFile &CacheFile)
 {
 {
@@ -430,7 +430,7 @@ pkgSrcRecords::Parser *FindSrc(const char *Name,pkgRecords &Recs,
 }
 }
 									/*}}}*/
 									/*}}}*/
 /* mark packages as automatically/manually installed.			{{{*/
 /* mark packages as automatically/manually installed.			{{{*/
-bool DoMarkAuto(CommandLine &CmdL)
+static bool DoMarkAuto(CommandLine &CmdL)
 {
 {
    bool Action = true;
    bool Action = true;
    int AutoMarkChanged = 0;
    int AutoMarkChanged = 0;
@@ -475,7 +475,7 @@ bool DoMarkAuto(CommandLine &CmdL)
 // DoDSelectUpgrade - Do an upgrade by following dselects selections	/*{{{*/
 // DoDSelectUpgrade - Do an upgrade by following dselects selections	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* Follows dselect's selections */
 /* Follows dselect's selections */
-bool DoDSelectUpgrade(CommandLine &CmdL)
+static bool DoDSelectUpgrade(CommandLine &CmdL)
 {
 {
    CacheFile Cache;
    CacheFile Cache;
    if (Cache.OpenForInstall() == false || Cache.CheckDeps() == false)
    if (Cache.OpenForInstall() == false || Cache.CheckDeps() == false)
@@ -551,7 +551,7 @@ bool DoDSelectUpgrade(CommandLine &CmdL)
 // DoClean - Remove download archives					/*{{{*/
 // DoClean - Remove download archives					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool DoClean(CommandLine &CmdL)
+static bool DoClean(CommandLine &CmdL)
 {
 {
    std::string const archivedir = _config->FindDir("Dir::Cache::archives");
    std::string const archivedir = _config->FindDir("Dir::Cache::archives");
    std::string const pkgcache = _config->FindFile("Dir::cache::pkgcache");
    std::string const pkgcache = _config->FindFile("Dir::cache::pkgcache");
@@ -599,7 +599,7 @@ class LogCleaner : public pkgArchiveCleaner
    };
    };
 };
 };
 
 
-bool DoAutoClean(CommandLine &CmdL)
+static bool DoAutoClean(CommandLine &CmdL)
 {
 {
    // Lock the archive directory
    // Lock the archive directory
    FileFd Lock;
    FileFd Lock;
@@ -623,7 +623,7 @@ bool DoAutoClean(CommandLine &CmdL)
 									/*}}}*/
 									/*}}}*/
 // DoDownload - download a binary					/*{{{*/
 // DoDownload - download a binary					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
-bool DoDownload(CommandLine &CmdL)
+static bool DoDownload(CommandLine &CmdL)
 {
 {
    CacheFile Cache;
    CacheFile Cache;
    if (Cache.ReadOnlyOpen() == false)
    if (Cache.ReadOnlyOpen() == false)
@@ -696,7 +696,7 @@ bool DoDownload(CommandLine &CmdL)
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* Opening automatically checks the system, this command is mostly used
 /* Opening automatically checks the system, this command is mostly used
    for debugging */
    for debugging */
-bool DoCheck(CommandLine &CmdL)
+static bool DoCheck(CommandLine &CmdL)
 {
 {
    CacheFile Cache;
    CacheFile Cache;
    Cache.Open();
    Cache.Open();
@@ -715,7 +715,7 @@ struct DscFile
    string Dsc;
    string Dsc;
 };
 };
 
 
-bool DoSource(CommandLine &CmdL)
+static bool DoSource(CommandLine &CmdL)
 {
 {
    CacheFile Cache;
    CacheFile Cache;
    if (Cache.Open(false) == false)
    if (Cache.Open(false) == false)
@@ -1016,7 +1016,7 @@ bool DoSource(CommandLine &CmdL)
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This function will look at the build depends list of the given source 
 /* This function will look at the build depends list of the given source 
    package and install the necessary packages to make it true, or fail. */
    package and install the necessary packages to make it true, or fail. */
-bool DoBuildDep(CommandLine &CmdL)
+static bool DoBuildDep(CommandLine &CmdL)
 {
 {
    CacheFile Cache;
    CacheFile Cache;
 
 
@@ -1410,7 +1410,7 @@ bool DoBuildDep(CommandLine &CmdL)
  * pool/ next to the deb itself)
  * pool/ next to the deb itself)
  * Example return: "pool/main/a/apt/apt_0.8.8ubuntu3" 
  * Example return: "pool/main/a/apt/apt_0.8.8ubuntu3" 
  */
  */
-string GetChangelogPath(CacheFile &Cache, 
+static string GetChangelogPath(CacheFile &Cache, 
                         pkgCache::PkgIterator Pkg,
                         pkgCache::PkgIterator Pkg,
                         pkgCache::VerIterator Ver)
                         pkgCache::VerIterator Ver)
 {
 {
@@ -1437,7 +1437,7 @@ string GetChangelogPath(CacheFile &Cache,
  * apt-get changelog mplayer-doc:
  * apt-get changelog mplayer-doc:
  *  http://packages.medibuntu.org/pool/non-free/m/mplayer/mplayer_1.0~rc4~try1.dsfg1-1ubuntu1+medibuntu1.changelog
  *  http://packages.medibuntu.org/pool/non-free/m/mplayer/mplayer_1.0~rc4~try1.dsfg1-1ubuntu1+medibuntu1.changelog
  */
  */
-bool GuessThirdPartyChangelogUri(CacheFile &Cache, 
+static bool GuessThirdPartyChangelogUri(CacheFile &Cache, 
                                  pkgCache::PkgIterator Pkg,
                                  pkgCache::PkgIterator Pkg,
                                  pkgCache::VerIterator Ver,
                                  pkgCache::VerIterator Ver,
                                  string &out_uri)
                                  string &out_uri)
@@ -1462,7 +1462,7 @@ bool GuessThirdPartyChangelogUri(CacheFile &Cache,
 									/*}}}*/
 									/*}}}*/
 // DownloadChangelog - Download the changelog 			        /*{{{*/
 // DownloadChangelog - Download the changelog 			        /*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
-bool DownloadChangelog(CacheFile &CacheFile, pkgAcquire &Fetcher, 
+static bool DownloadChangelog(CacheFile &CacheFile, pkgAcquire &Fetcher, 
                        pkgCache::VerIterator Ver, string targetfile)
                        pkgCache::VerIterator Ver, string targetfile)
 /* Download a changelog file for the given package version to
 /* Download a changelog file for the given package version to
  * targetfile. This will first try the server from Apt::Changelogs::Server
  * targetfile. This will first try the server from Apt::Changelogs::Server
@@ -1517,7 +1517,7 @@ bool DownloadChangelog(CacheFile &CacheFile, pkgAcquire &Fetcher,
 									/*}}}*/
 									/*}}}*/
 // DoChangelog - Get changelog from the command line			/*{{{*/
 // DoChangelog - Get changelog from the command line			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
-bool DoChangelog(CommandLine &CmdL)
+static bool DoChangelog(CommandLine &CmdL)
 {
 {
    CacheFile Cache;
    CacheFile Cache;
    if (Cache.ReadOnlyOpen() == false)
    if (Cache.ReadOnlyOpen() == false)
@@ -1581,7 +1581,7 @@ bool DoChangelog(CommandLine &CmdL)
 // ShowHelp - Show a help screen					/*{{{*/
 // ShowHelp - Show a help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &CmdL)
+static bool ShowHelp(CommandLine &CmdL)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);
@@ -1677,7 +1677,7 @@ bool ShowHelp(CommandLine &CmdL)
 // SigWinch - Window size change signal handler				/*{{{*/
 // SigWinch - Window size change signal handler				/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-void SigWinch(int)
+static void SigWinch(int)
 {
 {
    // Riped from GNU ls
    // Riped from GNU ls
 #ifdef TIOCGWINSZ
 #ifdef TIOCGWINSZ

+ 2 - 2
cmdline/apt-helper.cc

@@ -33,7 +33,7 @@
 									/*}}}*/
 									/*}}}*/
 using namespace std;
 using namespace std;
 
 
-bool DoDownloadFile(CommandLine &CmdL)
+static bool DoDownloadFile(CommandLine &CmdL)
 {
 {
    if (CmdL.FileSize() <= 2)
    if (CmdL.FileSize() <= 2)
       return _error->Error(_("Must specify at least one pair url/filename"));
       return _error->Error(_("Must specify at least one pair url/filename"));
@@ -55,7 +55,7 @@ bool DoDownloadFile(CommandLine &CmdL)
    return true;
    return true;
 }
 }
 
 
-bool ShowHelp(CommandLine &CmdL)
+static bool ShowHelp(CommandLine &CmdL)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 1 - 1
cmdline/apt-internal-solver.cc

@@ -30,7 +30,7 @@
 // ShowHelp - Show a help screen					/*{{{*/
 // ShowHelp - Show a help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &CmdL) {
+static bool ShowHelp(CommandLine &CmdL) {
 	ioprintf(std::cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	ioprintf(std::cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 		 COMMON_ARCH,__DATE__,__TIME__);
 		 COMMON_ARCH,__DATE__,__TIME__);
 
 

+ 6 - 6
cmdline/apt-mark.cc

@@ -35,7 +35,7 @@ ostream c1out(0);
 ostream c2out(0);
 ostream c2out(0);
 ofstream devnull("/dev/null");
 ofstream devnull("/dev/null");
 /* DoAuto - mark packages as automatically/manually installed		{{{*/
 /* DoAuto - mark packages as automatically/manually installed		{{{*/
-bool DoAuto(CommandLine &CmdL)
+static bool DoAuto(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -82,7 +82,7 @@ bool DoAuto(CommandLine &CmdL)
 /* DoMarkAuto - mark packages as automatically/manually installed	{{{*/
 /* DoMarkAuto - mark packages as automatically/manually installed	{{{*/
 /* Does the same as DoAuto but tries to do it exactly the same why as
 /* Does the same as DoAuto but tries to do it exactly the same why as
    the python implementation did it so it can be a drop-in replacement */
    the python implementation did it so it can be a drop-in replacement */
-bool DoMarkAuto(CommandLine &CmdL)
+static bool DoMarkAuto(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -119,7 +119,7 @@ bool DoMarkAuto(CommandLine &CmdL)
 }
 }
 									/*}}}*/
 									/*}}}*/
 /* ShowAuto - show automatically installed packages (sorted)		{{{*/
 /* ShowAuto - show automatically installed packages (sorted)		{{{*/
-bool ShowAuto(CommandLine &CmdL)
+static bool ShowAuto(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -159,7 +159,7 @@ bool ShowAuto(CommandLine &CmdL)
 }
 }
 									/*}}}*/
 									/*}}}*/
 /* DoHold - mark packages as hold by dpkg				{{{*/
 /* DoHold - mark packages as hold by dpkg				{{{*/
-bool DoHold(CommandLine &CmdL)
+static bool DoHold(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -335,7 +335,7 @@ bool DoHold(CommandLine &CmdL)
 }
 }
 									/*}}}*/
 									/*}}}*/
 /* ShowHold - show packages set on hold in dpkg status			{{{*/
 /* ShowHold - show packages set on hold in dpkg status			{{{*/
-bool ShowHold(CommandLine &CmdL)
+static bool ShowHold(CommandLine &CmdL)
 {
 {
    pkgCacheFile CacheFile;
    pkgCacheFile CacheFile;
    pkgCache *Cache = CacheFile.GetPkgCache();
    pkgCache *Cache = CacheFile.GetPkgCache();
@@ -372,7 +372,7 @@ bool ShowHold(CommandLine &CmdL)
 // ShowHelp - Show a help screen					/*{{{*/
 // ShowHelp - Show a help screen					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &CmdL)
+static bool ShowHelp(CommandLine &CmdL)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 2 - 2
cmdline/apt-sortpkgs.cc

@@ -62,7 +62,7 @@ struct PkgName								/*{{{*/
 // DoIt - Sort a single file						/*{{{*/
 // DoIt - Sort a single file						/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool DoIt(string InFile)
+static bool DoIt(string InFile)
 {
 {
    FileFd Fd(InFile,FileFd::ReadOnly);
    FileFd Fd(InFile,FileFd::ReadOnly);
    pkgTagFile Tags(&Fd);
    pkgTagFile Tags(&Fd);
@@ -142,7 +142,7 @@ bool DoIt(string InFile)
 // ShowHelp - Show the help text					/*{{{*/
 // ShowHelp - Show the help text					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-int ShowHelp()
+static int ShowHelp()
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 1 - 1
cmdline/apt.cc

@@ -61,7 +61,7 @@
 
 
 
 
 
 
-bool ShowHelp(CommandLine &CmdL)
+static bool ShowHelp(CommandLine &CmdL)
 {
 {
    ioprintf(c1out,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(c1out,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);

+ 0 - 1
debian/libapt-pkg4.12.symbols

@@ -1197,7 +1197,6 @@ libapt-pkg.so.4.12 libapt-pkg4.12 #MINVER#
  (c++)"APT::Configuration::setDefaultConfigurationForCompressors()@Base" 0.8.12
  (c++)"APT::Configuration::setDefaultConfigurationForCompressors()@Base" 0.8.12
  (c++)"pkgAcqMetaClearSig::Custom600Headers()@Base" 0.8.13
  (c++)"pkgAcqMetaClearSig::Custom600Headers()@Base" 0.8.13
  (c++|optional=private)"debListParser::NewProvidesAllArch(pkgCache::VerIterator&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)@Base" 0.8.13.2
  (c++|optional=private)"debListParser::NewProvidesAllArch(pkgCache::VerIterator&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)@Base" 0.8.13.2
- (c++|optional=private)"PrintMode(char)@Base" 0.8.13.2
  (c++)"pkgDepCache::IsModeChangeOk(pkgDepCache::ModeList, pkgCache::PkgIterator const&, unsigned long, bool)@Base" 0.8.13.2
  (c++)"pkgDepCache::IsModeChangeOk(pkgDepCache::ModeList, pkgCache::PkgIterator const&, unsigned long, bool)@Base" 0.8.13.2
  (c++)"pkgCache::DepIterator::IsNegative() const@Base" 0.8.15~exp1
  (c++)"pkgCache::DepIterator::IsNegative() const@Base" 0.8.15~exp1
  (c++)"Configuration::CndSet(char const*, int)@Base" 0.8.15.3
  (c++)"Configuration::CndSet(char const*, int)@Base" 0.8.15.3

+ 9 - 9
ftparchive/apt-ftparchive.cc

@@ -438,7 +438,7 @@ bool PackageMap::GenContents(Configuration &Setup,
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This populates the PkgList with all the possible permutations of the
 /* This populates the PkgList with all the possible permutations of the
    section/arch lists. */
    section/arch lists. */
-void LoadTree(vector<PackageMap> &PkgList,Configuration &Setup)
+static void LoadTree(vector<PackageMap> &PkgList,Configuration &Setup)
 {   
 {   
    // Load the defaults
    // Load the defaults
    string DDir = Setup.Find("TreeDefault::Directory",
    string DDir = Setup.Find("TreeDefault::Directory",
@@ -550,7 +550,7 @@ void LoadTree(vector<PackageMap> &PkgList,Configuration &Setup)
 // LoadBinDir - Load a 'bindirectory' section from the Generate Config	/*{{{*/
 // LoadBinDir - Load a 'bindirectory' section from the Generate Config	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-void LoadBinDir(vector<PackageMap> &PkgList,Configuration &Setup)
+static void LoadBinDir(vector<PackageMap> &PkgList,Configuration &Setup)
 {
 {
    mode_t const Permissions = Setup.FindI("Default::FileMode",0644);
    mode_t const Permissions = Setup.FindI("Default::FileMode",0644);
 
 
@@ -586,7 +586,7 @@ void LoadBinDir(vector<PackageMap> &PkgList,Configuration &Setup)
 // ShowHelp - Show the help text					/*{{{*/
 // ShowHelp - Show the help text					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool ShowHelp(CommandLine &CmdL)
+static bool ShowHelp(CommandLine &CmdL)
 {
 {
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
    ioprintf(cout,_("%s %s for %s compiled on %s %s\n"),PACKAGE,PACKAGE_VERSION,
 	    COMMON_ARCH,__DATE__,__TIME__);
 	    COMMON_ARCH,__DATE__,__TIME__);
@@ -639,7 +639,7 @@ bool ShowHelp(CommandLine &CmdL)
 // SimpleGenPackages - Generate a Packages file for a directory tree	/*{{{*/
 // SimpleGenPackages - Generate a Packages file for a directory tree	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This emulates dpkg-scanpackages's command line interface. 'mostly' */
 /* This emulates dpkg-scanpackages's command line interface. 'mostly' */
-bool SimpleGenPackages(CommandLine &CmdL)
+static bool SimpleGenPackages(CommandLine &CmdL)
 {
 {
    if (CmdL.FileSize() < 2)
    if (CmdL.FileSize() < 2)
       return ShowHelp(CmdL);
       return ShowHelp(CmdL);
@@ -667,7 +667,7 @@ bool SimpleGenPackages(CommandLine &CmdL)
 // SimpleGenContents - Generate a Contents listing			/*{{{*/
 // SimpleGenContents - Generate a Contents listing			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool SimpleGenContents(CommandLine &CmdL)
+static bool SimpleGenContents(CommandLine &CmdL)
 {
 {
    if (CmdL.FileSize() < 2)
    if (CmdL.FileSize() < 2)
       return ShowHelp(CmdL);
       return ShowHelp(CmdL);
@@ -689,7 +689,7 @@ bool SimpleGenContents(CommandLine &CmdL)
 // SimpleGenSources - Generate a Sources file for a directory tree	/*{{{*/
 // SimpleGenSources - Generate a Sources file for a directory tree	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* This emulates dpkg-scanpackages's command line interface. 'mostly' */
 /* This emulates dpkg-scanpackages's command line interface. 'mostly' */
-bool SimpleGenSources(CommandLine &CmdL)
+static bool SimpleGenSources(CommandLine &CmdL)
 {
 {
    if (CmdL.FileSize() < 2)
    if (CmdL.FileSize() < 2)
       return ShowHelp(CmdL);
       return ShowHelp(CmdL);
@@ -722,7 +722,7 @@ bool SimpleGenSources(CommandLine &CmdL)
 									/*}}}*/
 									/*}}}*/
 // SimpleGenRelease - Generate a Release file for a directory tree	/*{{{*/
 // SimpleGenRelease - Generate a Release file for a directory tree	/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
-bool SimpleGenRelease(CommandLine &CmdL)
+static bool SimpleGenRelease(CommandLine &CmdL)
 {
 {
    if (CmdL.FileSize() < 2)
    if (CmdL.FileSize() < 2)
       return ShowHelp(CmdL);
       return ShowHelp(CmdL);
@@ -747,7 +747,7 @@ bool SimpleGenRelease(CommandLine &CmdL)
 // Generate - Full generate, using a config file			/*{{{*/
 // Generate - Full generate, using a config file			/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Generate(CommandLine &CmdL)
+static bool Generate(CommandLine &CmdL)
 {
 {
    struct CacheDB::Stats SrcStats;
    struct CacheDB::Stats SrcStats;
    if (CmdL.FileSize() < 2)
    if (CmdL.FileSize() < 2)
@@ -911,7 +911,7 @@ bool Generate(CommandLine &CmdL)
 // Clean - Clean out the databases					/*{{{*/
 // Clean - Clean out the databases					/*{{{*/
 // ---------------------------------------------------------------------
 // ---------------------------------------------------------------------
 /* */
 /* */
-bool Clean(CommandLine &CmdL)
+static bool Clean(CommandLine &CmdL)
 {
 {
    if (CmdL.FileSize() != 2)
    if (CmdL.FileSize() != 2)
       return ShowHelp(CmdL);
       return ShowHelp(CmdL);

+ 15 - 15
test/interactive-helper/aptwebserver.cc

@@ -23,7 +23,7 @@
 #include <dirent.h>
 #include <dirent.h>
 #include <signal.h>
 #include <signal.h>
 
 
-char const * const httpcodeToStr(int const httpcode)			/*{{{*/
+static char const * const httpcodeToStr(int const httpcode)		/*{{{*/
 {
 {
    switch (httpcode)
    switch (httpcode)
    {
    {
@@ -77,7 +77,7 @@ char const * const httpcodeToStr(int const httpcode)			/*{{{*/
    return NULL;
    return NULL;
 }
 }
 									/*}}}*/
 									/*}}}*/
-void addFileHeaders(std::list<std::string> &headers, FileFd &data)	/*{{{*/
+static void addFileHeaders(std::list<std::string> &headers, FileFd &data)/*{{{*/
 {
 {
    std::ostringstream contentlength;
    std::ostringstream contentlength;
    contentlength << "Content-Length: " << data.FileSize();
    contentlength << "Content-Length: " << data.FileSize();
@@ -88,14 +88,14 @@ void addFileHeaders(std::list<std::string> &headers, FileFd &data)	/*{{{*/
    headers.push_back(lastmodified);
    headers.push_back(lastmodified);
 }
 }
 									/*}}}*/
 									/*}}}*/
-void addDataHeaders(std::list<std::string> &headers, std::string &data)	/*{{{*/
+static void addDataHeaders(std::list<std::string> &headers, std::string &data)/*{{{*/
 {
 {
    std::ostringstream contentlength;
    std::ostringstream contentlength;
    contentlength << "Content-Length: " << data.size();
    contentlength << "Content-Length: " << data.size();
    headers.push_back(contentlength.str());
    headers.push_back(contentlength.str());
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool sendHead(int const client, int const httpcode, std::list<std::string> &headers)/*{{{*/
+static bool sendHead(int const client, int const httpcode, std::list<std::string> &headers)/*{{{*/
 {
 {
    std::string response("HTTP/1.1 ");
    std::string response("HTTP/1.1 ");
    response.append(httpcodeToStr(httpcode));
    response.append(httpcodeToStr(httpcode));
@@ -128,7 +128,7 @@ bool sendHead(int const client, int const httpcode, std::list<std::string> &head
    return Success;
    return Success;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool sendFile(int const client, FileFd &data)				/*{{{*/
+static bool sendFile(int const client, FileFd &data)			/*{{{*/
 {
 {
    bool Success = true;
    bool Success = true;
    char buffer[500];
    char buffer[500];
@@ -144,7 +144,7 @@ bool sendFile(int const client, FileFd &data)				/*{{{*/
    return Success;
    return Success;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool sendData(int const client, std::string const &data)		/*{{{*/
+static bool sendData(int const client, std::string const &data)		/*{{{*/
 {
 {
    if (FileFd::Write(client, data.c_str(), data.size()) == false)
    if (FileFd::Write(client, data.c_str(), data.size()) == false)
    {
    {
@@ -154,7 +154,7 @@ bool sendData(int const client, std::string const &data)		/*{{{*/
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-void sendError(int const client, int const httpcode, std::string const &request,/*{{{*/
+static void sendError(int const client, int const httpcode, std::string const &request,/*{{{*/
 	       bool content, std::string const &error = "")
 	       bool content, std::string const &error = "")
 {
 {
    std::list<std::string> headers;
    std::list<std::string> headers;
@@ -179,13 +179,13 @@ void sendError(int const client, int const httpcode, std::string const &request,
    if (content == true)
    if (content == true)
       sendData(client, response);
       sendData(client, response);
 }
 }
-void sendSuccess(int const client, std::string const &request,
+static void sendSuccess(int const client, std::string const &request,
 	       bool content, std::string const &error = "")
 	       bool content, std::string const &error = "")
 {
 {
    sendError(client, 200, request, content, error);
    sendError(client, 200, request, content, error);
 }
 }
 									/*}}}*/
 									/*}}}*/
-void sendRedirect(int const client, int const httpcode, std::string const &uri,/*{{{*/
+static void sendRedirect(int const client, int const httpcode, std::string const &uri,/*{{{*/
 		  std::string const &request, bool content)
 		  std::string const &request, bool content)
 {
 {
    std::list<std::string> headers;
    std::list<std::string> headers;
@@ -222,7 +222,7 @@ void sendRedirect(int const client, int const httpcode, std::string const &uri,/
       sendData(client, response);
       sendData(client, response);
 }
 }
 									/*}}}*/
 									/*}}}*/
-int filter_hidden_files(const struct dirent *a)				/*{{{*/
+static int filter_hidden_files(const struct dirent *a)			/*{{{*/
 {
 {
    if (a->d_name[0] == '.')
    if (a->d_name[0] == '.')
       return 0;
       return 0;
@@ -236,7 +236,7 @@ int filter_hidden_files(const struct dirent *a)				/*{{{*/
 #endif
 #endif
    return 1;
    return 1;
 }
 }
-int grouped_alpha_case_sort(const struct dirent **a, const struct dirent **b) {
+static int grouped_alpha_case_sort(const struct dirent **a, const struct dirent **b) {
 #ifdef _DIRENT_HAVE_D_TYPE
 #ifdef _DIRENT_HAVE_D_TYPE
    if ((*a)->d_type == DT_DIR && (*b)->d_type == DT_DIR);
    if ((*a)->d_type == DT_DIR && (*b)->d_type == DT_DIR);
    else if ((*a)->d_type == DT_DIR && (*b)->d_type == DT_REG)
    else if ((*a)->d_type == DT_DIR && (*b)->d_type == DT_REG)
@@ -260,7 +260,7 @@ int grouped_alpha_case_sort(const struct dirent **a, const struct dirent **b) {
    return strcasecmp((*a)->d_name, (*b)->d_name);
    return strcasecmp((*a)->d_name, (*b)->d_name);
 }
 }
 									/*}}}*/
 									/*}}}*/
-void sendDirectoryListing(int const client, std::string const &dir,	/*{{{*/
+static void sendDirectoryListing(int const client, std::string const &dir,/*{{{*/
 			  std::string const &request, bool content)
 			  std::string const &request, bool content)
 {
 {
    std::list<std::string> headers;
    std::list<std::string> headers;
@@ -312,7 +312,7 @@ void sendDirectoryListing(int const client, std::string const &dir,	/*{{{*/
       sendData(client, response);
       sendData(client, response);
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool parseFirstLine(int const client, std::string const &request,	/*{{{*/
+static bool parseFirstLine(int const client, std::string const &request,/*{{{*/
 		    std::string &filename, std::string &params, bool &sendContent,
 		    std::string &filename, std::string &params, bool &sendContent,
 		    bool &closeConnection)
 		    bool &closeConnection)
 {
 {
@@ -432,7 +432,7 @@ bool parseFirstLine(int const client, std::string const &request,	/*{{{*/
    return true;
    return true;
 }
 }
 									/*}}}*/
 									/*}}}*/
-bool handleOnTheFlyReconfiguration(int const client, std::string const &request, std::vector<std::string> const &parts)/*{{{*/
+static bool handleOnTheFlyReconfiguration(int const client, std::string const &request, std::vector<std::string> const &parts)/*{{{*/
 {
 {
    size_t const pcount = parts.size();
    size_t const pcount = parts.size();
    if (pcount == 4 && parts[1] == "set")
    if (pcount == 4 && parts[1] == "set")
@@ -475,7 +475,7 @@ bool handleOnTheFlyReconfiguration(int const client, std::string const &request,
    return false;
    return false;
 }
 }
 									/*}}}*/
 									/*}}}*/
-void * handleClient(void * voidclient)					/*{{{*/
+static void * handleClient(void * voidclient)				/*{{{*/
 {
 {
    int client = *((int*)(voidclient));
    int client = *((int*)(voidclient));
    std::clog << "ACCEPT client " << client << std::endl;
    std::clog << "ACCEPT client " << client << std::endl;

+ 1 - 1
test/interactive-helper/extract-control.cc

@@ -7,7 +7,7 @@
 
 
 using namespace std;
 using namespace std;
 
 
-bool ExtractMember(const char *File,const char *Member)
+static bool ExtractMember(const char *File,const char *Member)
 {
 {
    FileFd Fd(File,FileFd::ReadOnly);
    FileFd Fd(File,FileFd::ReadOnly);
    debDebFile Deb(Fd);
    debDebFile Deb(Fd);

+ 1 - 1
test/interactive-helper/testdeb.cc

@@ -9,7 +9,7 @@ class NullStream : public pkgDirStream
    virtual bool DoItem(Item &Itm,int &Fd) {return true;};
    virtual bool DoItem(Item &Itm,int &Fd) {return true;};
 };
 };
 
 
-bool Test(const char *File)
+static bool Test(const char *File)
 {
 {
    FileFd Fd(File,FileFd::ReadOnly);
    FileFd Fd(File,FileFd::ReadOnly);
    debDebFile Deb(Fd);
    debDebFile Deb(Fd);

+ 9 - 0
test/libapt/assert.h

@@ -1,6 +1,11 @@
 #include <iostream>
 #include <iostream>
 #include <cstdlib>
 #include <cstdlib>
 
 
+#if __GNUC__ >= 4
+	#pragma GCC diagnostic push
+	#pragma GCC diagnostic ignored "-Wmissing-declarations"
+#endif
+
 #define equals(x,y) assertEquals(y, x, __LINE__)
 #define equals(x,y) assertEquals(y, x, __LINE__)
 #define equalsNot(x,y) assertEqualsNot(y, x, __LINE__)
 #define equalsNot(x,y) assertEqualsNot(y, x, __LINE__)
 
 
@@ -111,3 +116,7 @@ void dumpVector(X vec) {
 	     v != vec.end(); ++v)
 	     v != vec.end(); ++v)
 		std::cout << *v << std::endl;
 		std::cout << *v << std::endl;
 }
 }
+
+#if __GNUC__ >= 4
+	#pragma GCC diagnostic pop
+#endif

+ 3 - 3
test/libapt/compareversion_test.cc

@@ -31,7 +31,7 @@
 
 
 using namespace std;
 using namespace std;
 
 
-bool callDPkg(const char *val, const char *ref, const char &op) {
+static bool callDPkg(const char *val, const char *ref, const char &op) {
    pid_t Process = ExecFork();
    pid_t Process = ExecFork();
    if (Process == 0)
    if (Process == 0)
    {
    {
@@ -50,7 +50,7 @@ bool callDPkg(const char *val, const char *ref, const char &op) {
    return WIFEXITED(Ret) == true && WEXITSTATUS(Ret) == 0;
    return WIFEXITED(Ret) == true && WEXITSTATUS(Ret) == 0;
 }
 }
 
 
-void assertVersion(int const &CurLine, string const &A, string const &B, int const &Expected) {
+static void assertVersion(int const &CurLine, string const &A, string const &B, int const &Expected) {
    int Res = debVS.CmpVersion(A.c_str(), B.c_str());
    int Res = debVS.CmpVersion(A.c_str(), B.c_str());
    bool const dpkg = callDPkg(A.c_str(),B.c_str(), Expected);
    bool const dpkg = callDPkg(A.c_str(),B.c_str(), Expected);
    Res = (Res < 0) ? -1 : ( (Res > 0) ? 1 : Res);
    Res = (Res < 0) ? -1 : ( (Res > 0) ? 1 : Res);
@@ -61,7 +61,7 @@ void assertVersion(int const &CurLine, string const &A, string const &B, int con
       _error->Error("DPkg differ with line: %u. '%s' '%s' '%s' == false",CurLine,A.c_str(),((Expected == 1) ? "<<" : ( (Expected == 0) ? "=" : ">>")),B.c_str());
       _error->Error("DPkg differ with line: %u. '%s' '%s' '%s' == false",CurLine,A.c_str(),((Expected == 1) ? "<<" : ( (Expected == 0) ? "=" : ">>")),B.c_str());
 }
 }
 
 
-bool RunTest(const char *File)
+static bool RunTest(const char *File)
 {
 {
    if (FileExists(File) == false)
    if (FileExists(File) == false)
       return _error->Error("Versiontestfile %s doesn't exist!", File);
       return _error->Error("Versiontestfile %s doesn't exist!", File);

+ 1 - 1
test/libapt/sourcelist_test.cc

@@ -9,7 +9,7 @@
 char *tempfile = NULL;
 char *tempfile = NULL;
 int tempfile_fd = -1;
 int tempfile_fd = -1;
 
 
-void remove_tmpfile(void)
+static void remove_tmpfile(void)
 {
 {
    if (tempfile_fd > 0)
    if (tempfile_fd > 0)
       close(tempfile_fd);
       close(tempfile_fd);

+ 1 - 1
test/libapt/tagfile_test.cc

@@ -9,7 +9,7 @@
 char *tempfile = NULL;
 char *tempfile = NULL;
 int tempfile_fd = -1;
 int tempfile_fd = -1;
 
 
-void remove_tmpfile(void)
+static void remove_tmpfile(void)
 {
 {
    if (tempfile_fd > 0)
    if (tempfile_fd > 0)
       close(tempfile_fd);
       close(tempfile_fd);